API Updates #1269
Merged
API Updates #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
approved these changes
Oct 11, 2021
| * The Klarna payment method used for this transaction. | ||
| * Can be one of `pay_later`, `pay_now`, `pay_with_financing`, or `pay_in_installments` | ||
| */ | ||
| payment_method_category?: string | null; |
There was a problem hiding this comment.
Shouldn't this be an enum?
There was a problem hiding this comment.
Yes, per IRL discussion I'm going to plow ahead - the team will update the API definition later and it should be safe to make a string->enum change in Typescript without interfering with users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codegen for openapi ef061d9.
r? @dcr-stripe
cc @stripe/api-libraries
Changelog
payment_method_categoryandpreferred_localeonCharge.payment_method_details.klarnaklarnaon enumsCustomerListPaymentMethodsParams.typeandPaymentMethodListParams.typeklarnaonPaymentIntentCreateParams.payment_method_data,PaymentIntentCreateParams.payment_method_options,PaymentIntentUpdateParams.payment_method_data,PaymentIntentUpdateParams.payment_method_options,PaymentIntentConfirmParams.payment_method_data,PaymentIntentConfirmParams.payment_method_options,PaymentIntent.payment_method_options,PaymentMethodCreateParams, andPaymentMethodklarnaon enumsPaymentIntentCreateParams.payment_method_data.type,PaymentIntentUpdateParams.payment_method_data.type, andPaymentIntentConfirmParams.payment_method_data.typeklarnaon enumPaymentMethodCreateParams.typeklarnaon enumPaymentMethod.type