Stop sending Content-Length header for verbs which don't have bodies. #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcr-stripe
force-pushed
the
dcr-method-content-length
branch
from
5a29284
to
b9f9fc1
Compare
| `https://${options.host}`, | ||
| // No Content-Length should be present for GET requests. | ||
| { | ||
| badheaders: ['Content-Length'], |
|
r? @yejia-stripe for calibration Thanks! |
yejia-stripe
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @pakrym-stripe
Summary
Stops sending a
Content-Lengthheader for requests which:GET,DELETE) andFor requests that don't anticipate a body but end up having one, we'll continue setting the header and emit a warning so that we can track and fix these cases as they are not following proper semantics.
POST,PUTandPATCHrequest are unchanged.Motivation
Fixes #1360