Add support for the Person resource #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-add-person
branch
from
9d52a4b
to
869c628
Compare
remi-stripe
commented
Oct 12, 2018
| it('Sends the correct request', function() { | ||
| person.create({ | ||
| first_name: "John", | ||
| }); |
There was a problem hiding this comment.
This part makes no sense to me. I know it works and why but that feels like a really weird way to approach this test and I'm ~confused why we even allow this.
There was a problem hiding this comment.
What part makes no sense?
There was a problem hiding this comment.
The part where to create a brand new object (which means said object does not exist yet) you use a pre-filled fake object.
remi-stripe
changed the title
remi-stripe
force-pushed
the
remi-add-person
branch
from
869c628
to
4958429
Compare
|
r? @ob-stripe |
ob-stripe
suggested changes
Oct 29, 2018
| headers: {}, | ||
| data: {first_name: 'John'}, | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Missing a test for update + specified auth.
remi-stripe
force-pushed
the
remi-add-person
branch
from
4958429
to
0c491a2
Compare
|
@ob-stripe PTAL |
ob-stripe
approved these changes
Oct 30, 2018
|
Released as 6.13.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @stripe/api-libraries