Prettier formatting #604
Merged
Prettier formatting #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/StripeMethod.basic.js
Outdated
| null, | ||
| path, | ||
| { | ||
| metadata: null, |
There was a problem hiding this comment.
minor, would you mind removing the newline before metadata here such that the output is {metadata: null}? this is the ~one place that prettier respects original formatting, annoyingly
… yarn and prettier
rattrayalex-stripe
force-pushed
the
irace-prettier-formatting
branch
from
c15d6e4
to
ea62a5f
Compare
rattrayalex-stripe
force-pushed
the
irace-prettier-formatting
branch
from
ea62a5f
to
ee3022f
Compare
rattrayalex-stripe
force-pushed
the
irace-prettier-formatting
branch
from
ee3022f
to
8ee5536
Compare
paulasjes-stripe
approved these changes
May 6, 2019
README.md
Outdated
| email: 'customer@example.com', | ||
| }, | ||
| function(err, customer) { | ||
| err; // null if no error occurred |
There was a problem hiding this comment.
Nit: Can we do something with these values? It looks a little odd by themselves. Perhaps something like:
if (err) {
// Deal with an error
}
// Do something with created customer object
console.log(customer.id)
|
@rattrayalex-stripe @paulasjes-stripe Feedback addressed. Since this was already approved and my changes were trivial, I’m going to merge this. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Prettier formatting.