Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敟Remove deprecated methods 馃敟 #613

Merged
merged 1 commit into from May 8, 2019

Conversation

ob-stripe
Copy link
Contributor

@ob-stripe ob-stripe commented May 8, 2019

r? @rattrayalex-stripe @remi-stripe
cc @stripe/api-libraries @irace-stripe

Remove all deprecated methods, as documented in https://github.com/stripe/stripe-node/wiki/Migration-guide-for-v7.

Copy link

@irace-stripe irace-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Left a couple of questions, many of which are probably not issues with this PR but just things that differ For Reasons and will need to be addressed via codegeneration overrides.

lib/resources/Balance.js Show resolved Hide resolved
lib/resources/Sources.js Show resolved Hide resolved
lib/resources/SubscriptionSchedules.js Show resolved Hide resolved
lib/resources/Issuing/Cards.js Show resolved Hide resolved
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

lib/resources/Issuing/Cards.js Show resolved Hide resolved
lib/resources/Recipients.js Show resolved Hide resolved
lib/resources/Recipients.js Outdated Show resolved Hide resolved
lib/resources/Transfers.js Show resolved Hide resolved
lib/stripe.js Show resolved Hide resolved
test/flows.spec.js Show resolved Hide resolved
Copy link
Contributor

@rattrayalex-stripe rattrayalex-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome!

LGTM

once remi's questions have been addressed

lib/resources/Balance.js Show resolved Hide resolved
lib/resources/Transfers.js Show resolved Hide resolved
test/flows.spec.js Show resolved Hide resolved
@rattrayalex-stripe
Copy link
Contributor

(per IRL, we'll add recipients.listCards back in and then merge)

@ob-stripe ob-stripe force-pushed the ob-remove-deprecated-methods branch from 0db7e03 to 51419c9 Compare May 8, 2019 21:57
@stripe-ci stripe-ci removed the approved label May 8, 2019
@ob-stripe ob-stripe merged commit 056d3fc into v7.0.0 May 8, 2019
@ob-stripe ob-stripe deleted the ob-remove-deprecated-methods branch May 8, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants