Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move generateTestHeaderString to stripe.webhooks #619

Merged
merged 1 commit into from
May 8, 2019

Conversation

paulasjes-stripe
Copy link
Contributor

Attempt 2!

Moved the header generator to a more reasonable place. This version is a little more strict with what you pass in, this is mainly because we don't want test constants in non-test code.

Also no longer requiring things that aren't whitelisted in .npmignore.

r? @rattrayalex-stripe @ob-stripe

@rattrayalex-stripe
Copy link
Contributor

For easy linking, this is a followup to #609 which fixes a bug raised here: #616

Copy link
Contributor

@rattrayalex-stripe rattrayalex-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @paulasjes-stripe !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants