Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "curried" nested resources and manually specified urlParams #625

Merged
merged 10 commits into from
May 10, 2019
Merged

Remove "curried" nested resources and manually specified urlParams #625

merged 10 commits into from
May 10, 2019

Commits on May 10, 2019

  1. Drop support for optional url params

    @rattrayalex-stripe
    rattrayalex-stripe committed May 10, 2019
    Configuration menu
    Copy the full SHA
    b8cbd25 View commit details
    Browse the repository at this point in the history

  2. Delete nested resource files

    @rattrayalex-stripe
    rattrayalex-stripe committed May 10, 2019
    Configuration menu
    Copy the full SHA
    d88a3e7 View commit details
    Browse the repository at this point in the history

  3. Remove urlData

    @rattrayalex-stripe
    rattrayalex-stripe committed May 10, 2019
    Configuration menu
    Copy the full SHA
    b3cfe88 View commit details
    Browse the repository at this point in the history

  4. Extract urlParams from path instead of manual definition 

    Verified this is no different with:

```js
const urlParams = utils.extractUrlParams(spec.path || '');
if (
  !(spec.urlParams || []).every((x, i) => urlParams[i] === x) ||
  (spec.urlParams || []).length !== urlParams.length
) {
  throw Error(
    'mismatch' + JSON.stringify(urlParams) + JSON.stringify(spec.urlParams)
  );
}
```

inside StripeMethod
    @rattrayalex-stripe
    rattrayalex-stripe committed May 10, 2019
    Configuration menu
    Copy the full SHA
    aeabd82 View commit details
    Browse the repository at this point in the history

  5. Remove manually specified urlParams

    @rattrayalex-stripe
    rattrayalex-stripe committed May 10, 2019
    Configuration menu
    Copy the full SHA
    7842939 View commit details
    Browse the repository at this point in the history

  6. Add a deprecation error message

    @rattrayalex-stripe
    rattrayalex-stripe committed May 10, 2019
    Configuration menu
    Copy the full SHA
    e52219b View commit details
    Browse the repository at this point in the history

  7. Revert "Delete nested resource files" 

    This reverts commit d88a3e7.
    @rattrayalex-stripe
    rattrayalex-stripe committed May 10, 2019
    Configuration menu
    Copy the full SHA
    e5eccb8 View commit details
    Browse the repository at this point in the history

  8. Fix nested resources for non-curried urlParams and update tests to de… 

    …monstrate their use
    @rattrayalex-stripe
    rattrayalex-stripe committed May 10, 2019
    Configuration menu
    Copy the full SHA
    71d5200 View commit details
    Browse the repository at this point in the history

  9. Refactor makeRequest

    @rattrayalex-stripe
    rattrayalex-stripe committed May 10, 2019
    Configuration menu
    Copy the full SHA
    f650b77 View commit details
    Browse the repository at this point in the history

  10. Revert "Revert "Delete nested resource files"" 

    This reverts commit e5eccb8.
    @rattrayalex-stripe
    rattrayalex-stripe committed May 10, 2019
    Configuration menu
    Copy the full SHA
    d58bbf8 View commit details
    Browse the repository at this point in the history