Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPDoc improvements #1019

Merged
merged 1 commit into from
Sep 25, 2020
Merged

PHPDoc improvements #1019

merged 1 commit into from
Sep 25, 2020

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Sep 25, 2020

Our PHPDocs for a couple "polymorphic groups" have used \Stripe\StripeObject as a fallback, but our codegen is now capable of providing a more specific union type in a couple of these instances.
r? @ctrudeau-stripe
cc @stripe/api-libraries

@richardm-stripe richardm-stripe changed the title [codegen] Update API Resources PHPDoc improvements Sep 25, 2020
Copy link
Contributor

@ctrudeau-stripe ctrudeau-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardm-stripe richardm-stripe merged commit 4119abf into master Sep 25, 2020
@remi-stripe remi-stripe deleted the richardm/codegen-c4ce6f6 branch July 25, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants