Add streaming methods to Service infra #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcr-stripe
suggested changes
Jul 9, 2021
| * Defaults to false. | ||
| * @param null|string $base base URL (e.g. 'https://api.stripe.com') | ||
| */ | ||
| protected function expectsRequestStream( |
There was a problem hiding this comment.
Should we add a test that uses this? Maybe on Quotes?
There was a problem hiding this comment.
Yes, I will rebase latest-codegen after this is merged, and that PR contains such a test.
Wanted to separate out the infra stuff in this PR vs. the actual quotes-related functionality.
richardm-stripe
force-pushed
the
richardm-extend-streaming-to-services
branch
2 times, most recently
from
7f14244
to
0ab0d03
Compare
richardm-stripe
force-pushed
the
richardm-extend-streaming-to-services
branch
from
dffe20a
to
95093c4
Compare
|
r? @dcr
|
dcr-stripe
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @dcr-stripe
#1143 was sufficient for adding Streaming support to
CurlClientThis PR adds analogous methods onto
AbstractStripeService,BaseStripeClientand such.Adding
requestStreamontoHttpClient\ClientInterfacedirectly would technically be a breaking change, so I am now exposing separate interfaces forrequestStreamandrequest, and I store two separate references on ApiRequestor.Changelog
setStreamingHttpClientandstreamingHttpClienttoApiRequestorgetStreamingClientandrequestStreamtoAbstractServicerequestStreamtoBaseStripeClient\Stripe\RequestOptions::parsenow clones its input if it is already aRequestOptionsobject, to prevent accidental mutation.