Add missing constant for payment_behavior #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For subscriptions, there is also `payment_behavior=default_incomplete`, of which the constant was missing. See: https://stripe.com/docs/api/subscriptions/create#create_subscription-payment_behavior And: https://stripe.com/docs/api/subscriptions/update#update_subscription-payment_behavior
|
|
|
@LeonMelis Thanks a lot for catching and submitting a PR. Can I ask you to order the constant alphabetically with the other 3? It should go after |
Place constants in alphabetical order
|
Sure. It should now be in alphabetical order |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For subscriptions, there is also
payment_behavior=default_incomplete, of which the constant was missing.See: https://stripe.com/docs/api/subscriptions/create#create_subscription-payment_behavior
And: https://stripe.com/docs/api/subscriptions/update#update_subscription-payment_behavior
Also note that the API documentation could really use some improving here. The difference between 'default_incomplete' and 'allow_incomplete' in the scope of updating subscriptions is unclear to me.