Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not force resolution to IPV4 addresses #1631

Conversation

pakrym-stripe
Copy link
Contributor

@pakrym-stripe pakrym-stripe commented Jan 12, 2024

Stripe does not have an AAAA record so it's impossible to resolve an IPv6 address for api.stripe.com.

Forcing resolution to IPv4 via CURL_IPRESOLVE_V4 interferes with IPv4 over IPv6 proxy network setups and DNS64.

We also don't enforce the same setting in any of the other libraries.

Changelog

  • Do not force resolution to IPv4 - Forcing IPv4 was causing hard-to-understand failures for users in IPv6-only environments. If you want to force IPv4 yourself, you can do so by telling the API client to use a CurlClient other than the default
$curl = new \Stripe\HttpClient\CurlClient([CURLOPT_IPRESOLVE => CURL_IPRESOLVE_V4]);
\Stripe\ApiRequestor::setHttpClient($curl);

Copy link
Contributor

@richardm-stripe richardm-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's write a careful ## Changelog in the PR description so that if any users begin suffering from #1045, they can find the workaround and we can investigate.

@pakrym-stripe
Copy link
Contributor Author

We'll wait until the next major to merge this.

@ramya-stripe ramya-stripe reopened this Mar 19, 2024
@ramya-stripe ramya-stripe changed the base branch from master to sdk-release/next-major March 19, 2024 18:18
@ramya-stripe
Copy link
Contributor

@pakrym-stripe, @richardm-stripe, Reviving this PR with the base as the next-major branch. This is stiil a go?

@pakrym-stripe
Copy link
Contributor Author

@ramya-stripe , yes, but needs a changelog entry as @richardm-stripe mentioned.

@ramya-stripe ramya-stripe merged commit 3e4196d into sdk-release/next-major Mar 25, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants