Add __debugInfo() magic method #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
force-pushed
the
ob-debug-info
branch
from
e22d646
to
6367cc5
Compare
|
Good call. LGTM. |
|
Released as 5.8.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
Adds a
__debugInfo()method toStripeObject. This is a magic method that is called byvar_dumpand returns the array of values that should be displayed. Returning$this->_valuesmakes the output much more legible and avoids inadvertently leaking credentials (the secret API keys is stored in$this->_optsand displayed by default).This is similar to what we do in other libraries, e.g. stripe-ruby or stripe-python.