Added and corrected @property phpdocs for API resources #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdnk
changed the title
|
Thanks @nickdnk! This is definitely a lot of work to get right, and we appreciate it. |
|
You're welcome! Would you mind releasing a version 5.9.1 (for instance) to composer to get these into production? |
|
Thanks :)
Finally I can get rid of all the warnings in PHPStorm!
On 7 Feb 2018, at 04.01, Olivier Bellone <notifications@github.com<mailto:notifications@github.com>> wrote:
@nickdnk<https://github.com/nickdnk> I just released v5.9.1<https://github.com/stripe/stripe-php/releases/tag/v5.9.1> -- it should be available via Composer / Packagist soon.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#427 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AIBYsrf9Nhzk6BwnJibiUlpZywV6u21Cks5tSRIQgaJpZM4RvHbB>.
|
|
You're welcome, thanks for the contribution! :) |
|
Found one that you might of missed, the country spec class. |
|
You're right, @shadow2004. I'll add that to my new PR with updates for the just-released API version: #431 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys
I added phpdocs for quite a few of the API objects. I also corrected some of them according to the latest docs on the website. I use these a lot in my development process and figured maybe someone else did too.