Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added phpDoc for ApiRequestor, especially regarding thrown errors #472

Merged
merged 5 commits into from
Jun 13, 2018

Conversation

rtm-ctrlz
Copy link
Contributor

No description provided.

Copy link
Contributor

@brandur-stripe brandur-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments, but generally LGTM. Thanks!

lib/ApiRequestor.php Outdated Show resolved Hide resolved
lib/ApiRequestor.php Outdated Show resolved Hide resolved
@rtm-ctrlz
Copy link
Contributor Author

ptal @brandur-stripe

@brandur-stripe
Copy link
Contributor

Thanks for circling back on this @rtm-ctrlz. I'd missed a couple other instances where HttpClient\ClientInterface should be used and added comments on the lines above. Otherwise, LGTM.

@rtm-ctrlz
Copy link
Contributor Author

Fixed CurlClient -> ClientInterface
Also I had to fix phpdoc for ClientInterface interface since @throws and @return sections was broken

ptal @brandur-stripe

@brandur-stripe
Copy link
Contributor

Also I had to fix phpdoc for ClientInterface interface since @throws and @return sections was broken

Oh nice.

LGTM. Thanks!

@brandur-stripe brandur-stripe merged commit 0a32b7c into stripe:master Jun 13, 2018
@brandur-stripe
Copy link
Contributor

Released as 6.8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants