Better classUrl()
#498
Merged
Better classUrl()
#498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
approved these changes
Jul 18, 2018
| * @return string The name of the class, with namespacing and underscores | ||
| * stripped. | ||
| */ | ||
| public static function className() |
There was a problem hiding this comment.
I'm so glad to see this one go
lib/ApiResource.php
Outdated
| @@ -103,7 +79,7 @@ public static function baseUrl() | |||
| */ | |||
| public static function classUrl() | |||
| { | |||
| $base = static::className(); | |||
| $base = str_replace('.', '/', static::OBJECT_NAME); | |||
There was a problem hiding this comment.
we likely should add a comment about that one to be clearer/more discoverable in the future
lib/SingletonApiResource.php
Outdated
| @@ -22,7 +22,7 @@ protected static function _singletonRetrieve($options = null) | |||
| */ | |||
| public static function classUrl() | |||
| { | |||
| $base = static::className(); | |||
| $base = static::OBJECT_NAME; | |||
There was a problem hiding this comment.
OOC what is that file about? I don't remember seeing it before
There was a problem hiding this comment.
The only singleton resource is Balance. I guess that we expected this to be a more common pattern in the API than it ended up being.
|
LGTM. Very nice cleanup! |
ob-stripe
force-pushed
the
ob-better-classurl
branch
from
6cbb9b2
to
8111deb
Compare
ob-stripe
force-pushed
the
ob-better-classurl
branch
from
8111deb
to
1ae9095
Compare
|
Released as 6.10.4. |
This was referenced Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries
Simplifies
classUrl()by using the recently-addedOBJECT_NAMEclass constants. RemovesclassName()entirely.