Add support for the Reporting resources #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-add-reporting-resources
branch
2 times, most recently
from
12c85cc
to
6456fb8
Compare
remi-stripe
changed the title
|
We resolved all the issues internally and it's ready to be merged. |
lib/Reporting/ReportType.php
Outdated
| * @property string $version | ||
| * @property mixed $result | ||
| * @property string $status | ||
| * @property int $succeeded_at |
There was a problem hiding this comment.
I'm not seeing result/status/succeeded_at in the implementation. Are you sure those are still relevant?
There was a problem hiding this comment.
hmmm looks like a bad copy paste, fixing
remi-stripe
force-pushed
the
remi-add-reporting-resources
branch
from
6456fb8
to
cf8be01
Compare
|
@brandur-stripe PTAL (And thank you for catching this mistake) |
|
LGTM. |
|
Released as 6.17.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for the new Reporting resources. Those are in OpenAPI but not yet public but since they are starting to be used and are stable we should merge them.
It's WIP for now while I get some feedback on the implementation and the shape of the resources.
cc @stripe/api-libraries
cc @brahn-stripe