Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case when adding a new additional owner to the array #522

Merged
merged 1 commit into from
Sep 18, 2018

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries @karlr-stripe

Fixes #521.

I've verified that without the fix, the new test does trigger the issue reported by @karlr-stripe in #521:

There was 1 error:

1) Stripe\AccountTest::testSerializeAddAdditionalOwners
Undefined offset: 2

/Users/ob/workspace/php/stripe-php/lib/Account.php:235
/Users/ob/workspace/php/stripe-php/lib/Account.php:208
/Users/ob/workspace/php/stripe-php/tests/Stripe/AccountTest.php:225

@brandur-stripe
Copy link
Contributor

LGTM.

@ob-stripe ob-stripe merged commit 2d7e164 into master Sep 18, 2018
@ob-stripe ob-stripe deleted the ob-fix-521 branch September 18, 2018 13:47
@ob-stripe
Copy link
Contributor Author

Released as 6.17.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E_NOTICE level error when updating additional owners.
2 participants