Bindings for Terminal endpoints #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
suggested changes
Sep 18, 2018
| '/v1/terminal/connection_tokens' | ||
| ); | ||
| $resource = ConnectionToken::create(); | ||
| $this->assertInstanceOf("Stripe\\Terminal\\ConnectionToken", $resource); |
There was a problem hiding this comment.
PHP uses 4 spaces for indents, but you only used only 2 spaces here.
| "city" => "San Francisco" | ||
| ] | ||
| ]); | ||
| $this->assertInstanceOf("Stripe\\Terminal\\Location", $resource); |
There was a problem hiding this comment.
Same indentation issue in this function.
tests/Stripe/Terminal/ReaderTest.php
Outdated
| ["registration_code" => "a-b-c"] | ||
| ); | ||
| $resource = Reader::create(['registration_code' => 'a-b-c']); | ||
| $this->assertInstanceOf("Stripe\\Terminal\\Reader", $resource); |
lib/Terminal/ConnectionToken.php
Outdated
| const OBJECT_NAME = "terminal.connection_token"; | ||
|
|
||
| use \Stripe\ApiOperations\Create; | ||
| } |
There was a problem hiding this comment.
Need to add a newline character at end of file to satisfy the linter.
lib/Terminal/Location.php
Outdated
| use \Stripe\ApiOperations\Create; | ||
| use \Stripe\ApiOperations\Retrieve; | ||
| use \Stripe\ApiOperations\Update; | ||
| } |
lib/Terminal/Reader.php
Outdated
| use \Stripe\ApiOperations\Create; | ||
| use \Stripe\ApiOperations\Retrieve; | ||
| use \Stripe\ApiOperations\Update; | ||
| } |
ob-stripe
reviewed
Sep 19, 2018
ob-stripe
approved these changes
Sep 19, 2018
daz-stripe
force-pushed
the
daz-terminal-bindings
branch
from
71e5e08
to
dddab39
Compare
lib/Terminal/ConnectionToken.php
Outdated
| /** | ||
| * Class ConnectionToken | ||
| * | ||
| * @property string $connection_token |
There was a problem hiding this comment.
Minor, but can we change this to the new $secret property?
|
ptal @daz-stripe |
|
Updated and fixed the misname! |
|
Thanks! |
|
Released as 6.19.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bindings for Terminal endpoints