Adjusted phpdocs to match API docs as of 2019-02-25 #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
requested changes
Feb 25, 2019
There was a problem hiding this comment.
@nickdnk Thanks a lot for the hard work as usual. I left a lot of comments this time, hope it's okay!
|
@remi-stripe I think I got all of them. I just noticed the problem with removing event constants as I received your reply. I forgot I was not in phpdoc-land for a second :) |
remi-stripe
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys
Back with some phpdoc updates. This is what I found this time around. Mostly just new or removed props, but we also have a somewhat critical typo in
application_fee_amountonPaymentIntentas well as some new event constants.Invoiceseems to have bothdateandcreatedon the docs, but onlycreatedis described, and since I assume they do the same I removeddate.Let me know if this looks good.