Use absolute value when checking timestamp tolerance #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur-stripe
approved these changes
May 20, 2019
There was a problem hiding this comment.
Looks great! (And happy this was reported — it probably should've been obvious, but often when thinking about time, things are not.)
Also, I've moved the signature check to happen before the event deserialization -- not much point deserializing the event if we're going to throw an exception afterwards.
Haha, good point. +1.
|
Thanks Brandur! Released as 6.35.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
Use absolute value when checking timestamp tolerance, since the local clock may be running either early or late compared to Stripe's clock.
Fixes #657.
Also, I've moved the signature check to happen before the event deserialization -- not much point deserializing the event if we're going to throw an exception afterwards.