Add new constants for collection_method on Invoice #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const BILLING_REASON_SUBSCRIPTION_CREATE = 'subscription_create'; | ||
| const BILLING_REASON_SUBSCRIPTION_CYCLE = 'subscription_cycle'; | ||
| const BILLING_REASON_SUBSCRIPTION_UPDATE = 'subscription_update'; | ||
| const BILLING_REASON_SUBSCRIPTION_THRESHOLD = 'subscription_threshold'; |
There was a problem hiding this comment.
Super nitpick: Looks like it was carried over from before, but minor misalphabetization here ("U" before "T").
| * @link https://stripe.com/docs/api/invoices/object#invoice_object-collection_method | ||
| */ | ||
| const COLLECTION_METHOD_SEND_INVOICE = 'send_invoice'; | ||
| const COLLECTION_METHOD_CHARGE_AUTOMATICALLY = 'charge_automatically'; |
There was a problem hiding this comment.
(And same down here.)
remi-stripe
force-pushed
the
remi-billing-new-constants
branch
from
60642a4
to
fc0c33f
Compare
remi-stripe
force-pushed
the
remi-billing-new-constants
branch
from
fc0c33f
to
8b56389
Compare
|
@brandur-stripe Nice catch. I think I fixed all of them. PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ob-stripe
cc @stripe/api-libraries