Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry requests on a 429 that's a lock timeout #718

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Retry requests on a 429 that's a lock timeout #718

merged 1 commit into from
Aug 28, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries

Similar to what we did in Ruby and Go.

@ob-stripe ob-stripe mentioned this pull request Aug 28, 2019
Merged
26 tasks
brandur-stripe
brandur-stripe reviewed Aug 28, 2019
View reviewed changes
Copy link
Contributor

@brandur-stripe brandur-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks OB! :) Left one question, but LGTM.

I was going to try and get to PHP, but started on Node yesterday and got a little stuck, so decided to pause the project for now haha.

lib/HttpClient/CurlClient.php Show resolved Hide resolved
@ob-stripe
Copy link
Contributor Author

Thanks!

@ob-stripe ob-stripe merged commit 0782b8b into integration-v7 Aug 28, 2019
@ob-stripe ob-stripe deleted the ob-retry-logic branch August 28, 2019 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandur-stripe brandur-stripe brandur-stripe approved these changes

Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ob-stripe @brandur-stripe @stripe-ci