Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early codegen fixes #788

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Early codegen fixes #788

merged 1 commit into from
Oct 31, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe @marko-stripe
cc @stripe/api-libraries

A bunch of fixes I pulled from @marko-stripe's almost-ready codegen branch:

  • fix a lot of PHPDoc blocks
  • use $opts instead of $options everywhere
  • standardize all but one methods to accept $params and $opts
    • the only exception is Dispute.close() which already accepts $opts, so adding $params first would be a breaking change. I left a TODO so we can fix in the next major version

lib/Event.php Outdated Show resolved Hide resolved
@ob-stripe ob-stripe merged commit b6b8bdd into master Oct 31, 2019
@ob-stripe ob-stripe deleted the ob-prep-codegen branch October 31, 2019 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants