More PHPDoc fixes #841
Merged
More PHPDoc fixes #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruudk
reviewed
Feb 3, 2020
| @@ -23,23 +23,23 @@ | |||
| * @property string|null $customer | |||
| * @property string|null $description | |||
| * @property string|null $invoice | |||
| * @property mixed|null $last_payment_error | |||
| * @property \Stripe\StripeObject|null $last_payment_error | |||
There was a problem hiding this comment.
@ob-stripe Shouldn't this be an \Stripe\ErrorObject type? That's how we always use it.
There was a problem hiding this comment.
@ruudk It is. We're currently switching to a a new "codegen" tool that automatically generates PHPDoc type annotations based on the OpenAPI specification for Stripe's API. The tool didn't know about \Stripe\ErrorObject, but that will be fixed very soon (it's already been fixed internally, we just need to update the public repository). Thanks for the report!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @cjavilla-stripe @remi-stripe
cc @stripe/api-libraries
More PHPDoc fixes from #837.