Types: annotate resource properties #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pakrym-stripe <99349468+pakrym-stripe@users.noreply.github.com>
richardm-stripe
force-pushed
the
richardm-resource-property-annotations
branch
from
7a82c06
to
d0b721e
Compare
richardm-stripe
changed the base branch from
master
to
richardm-generic-apiresource-parents
Base automatically changed from
richardm-generic-apiresource-parents
to
master
August 31, 2023 20:10
pakrym-stripe
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer
This should be ready to go right after #1032 (this is based off that rn)
Summary
This won't actually do much good without method return types being declared.(solved by Types for CRUDL methods on parents #1032)Anyfor now.