Explicitly define CRUDL methods in each resource #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
commented
Aug 30, 2023
richardm-stripe
force-pushed
the
richardm-explicit-methods
branch
3 times, most recently
from
011e834
to
46afe7b
Compare
richardm-stripe
force-pushed
the
richardm-explicit-methods
branch
from
46afe7b
to
8b6f7d5
Compare
richardm-stripe
changed the base branch from
master
to
richardm-rearrange-imports
richardm-stripe
requested review from
pakrym-stripe
and removed request for
pakrym-stripe
richardm-stripe
force-pushed
the
richardm-explicit-methods
branch
2 times, most recently
from
09b4781
to
48cabe1
Compare
richardm-stripe
force-pushed
the
richardm-explicit-methods
branch
from
48cabe1
to
ba2a9b6
Compare
pakrym-stripe
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly defines create, retrieve, update, delete, and list methods in the body of each resource, as an override of the "standard" implementation from
UpdateableApiResourceetc.This makes the class definition serve as better documentation and removes indirection. Eventually it would be good to do this for the "nested_resource" methods, too.
Branched off #1046.
Compare the CRUDL methods in coupon.py (left) with the parent class methods (right). They should be identical except for concrete classes instead of the generic
T.