Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter types #1078

Merged
merged 18 commits into from
Oct 13, 2023
Merged

Parameter types #1078

merged 18 commits into from
Oct 13, 2023

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Oct 13, 2023 •
edited

Add **params: Unpack[FooCreateParams] and corresponding Params class definitions to resource methods.

@richardm-stripe richardm-stripe requested review from a team and pakrym-stripe and removed request for a team October 13, 2023 20:52
pakrym-stripe
pakrym-stripe approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@pakrym-stripe pakrym-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely

@richardm-stripe richardm-stripe enabled auto-merge (squash) October 13, 2023 21:56
@richardm-stripe richardm-stripe merged commit f41d521 into master Oct 13, 2023
10 checks passed
richardm-stripe added a commit that referenced this pull request Oct 16, 2023
@richardm-stripe
Merge master into beta (#1082)
0ae74c6 
* Use latest pyright again (#1079)

* Parameter types (#1078)

* Add various type annotations (#1077)

* Polymorphic group types (#1080)
@richardm-stripe richardm-stripe deleted the richardm-params branch January 26, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakrym-stripe pakrym-stripe pakrym-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@richardm-stripe @pakrym-stripe