Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for error object #1115

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Conversation

richardm-stripe
Copy link
Contributor

Fixes #1114

Sanity checked against our definitions in another library

@richardm-stripe richardm-stripe requested review from a team and anniel-stripe and removed request for a team October 31, 2023 18:34
Copy link
Contributor

@anniel-stripe anniel-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops approved too soon, looks like there's some issues with the imports

@richardm-stripe richardm-stripe enabled auto-merge (squash) October 31, 2023 22:19
@richardm-stripe richardm-stripe merged commit 36d74d4 into master Oct 31, 2023
10 checks passed
@richardm-stripe richardm-stripe deleted the richardm-types-for-error-object branch January 26, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ErrorObject attributes are not visible to mypy
2 participants