Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move exports for more modules #1153

Conversation

pakrym-stripe
Copy link
Contributor

@pakrym-stripe pakrym-stripe commented Dec 7, 2023

Moves the rest of public modules to private and adds compatibility shims.

oauth_errors is the only module that I kept as is. Types from it conflict with standard error types.

Changelog

  • stripe.app_info, stripe.http_client, stripe.oauth, stripe.util, stripe.version, stripe.webhook, modules are deprecated. All types are available directly from stripe module now.
    Before:
    from stripe.util import convert_to_stripe_object
    # or
    stripe.util.convert_to_stripe_object
    After:
    from stripe import convert_to_stripe_object
    # or
    stripe.convert_to_stripe_object
  • stripe.api_version, stripe.multipart_data_generator, stripe.request_metrics are deprecated and will be fully removed in the future.

@pakrym-stripe pakrym-stripe force-pushed the pakrym/Move_exports_for_modules_that_will_become_internal branch from 8881adf to b243286 Compare December 7, 2023 15:34
@pakrym-stripe pakrym-stripe reopened this Dec 7, 2023
@pakrym-stripe pakrym-stripe force-pushed the pakrym/Move_exports_for_modules_that_will_become_internal branch 4 times, most recently from 7256364 to e66ad29 Compare December 7, 2023 17:00
@pakrym-stripe pakrym-stripe force-pushed the pakrym/Move_exports_for_modules_that_will_become_internal branch from 12476d5 to 3d25e4f Compare December 7, 2023 17:32
Copy link
Contributor

@anniel-stripe anniel-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

oauth_errors is the only module that I kept as is. Types from it conflict with standard error types.

Do we have a plan to make this module private in the future?

@pakrym-stripe pakrym-stripe merged commit b8dabab into master Dec 7, 2023
15 checks passed
@xavdid-stripe xavdid-stripe deleted the pakrym/Move_exports_for_modules_that_will_become_internal branch May 10, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants