Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated parameter util #1325

Merged
merged 1 commit into from
May 9, 2024

Conversation

prathmesh-stripe
Copy link
Contributor

We surveyed and found out the developers rarely read warning logs. They might not find this as helpful as IDE warnings. Hence rolling it back.

No usages in code. Does this need a changelog?

@prathmesh-stripe prathmesh-stripe force-pushed the prathmesh_remove_param_deprecation_util branch from 49e8aa1 to 203941b Compare May 9, 2024 15:39
Copy link
Contributor

@anniel-stripe anniel-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Does this need a changelog?

The title is descriptive enough IMO, and that'll get picked up in the Changelog.

@prathmesh-stripe prathmesh-stripe merged commit 71cf69e into master May 9, 2024
15 checks passed
@xavdid-stripe xavdid-stripe deleted the prathmesh_remove_param_deprecation_util branch May 10, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants