Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove util.json and use json module directly everywhere #402

Merged
merged 1 commit into from Feb 28, 2018

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries

Since we dropped simplejson, there's no point in centralizing all JSON usage through the util module anymore. Other modules can simply import the stdlib json module as needed.

@brandur-stripe
Copy link
Contributor

Oh man, the code quality here has improved like 2,000% YOY. Nice!

LGTM.

@ob-stripe ob-stripe merged commit abec0b6 into integration-v2 Feb 28, 2018
@ob-stripe ob-stripe deleted the ob-remove-util-json branch February 28, 2018 16:30
@ob-stripe ob-stripe mentioned this pull request Feb 28, 2018
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants