Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Issuing APIs/resources #455

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Conversation

remi-stripe
Copy link
Contributor

r? @ob-stripe
cc @stripe/api-libraries

Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, but feel free to ignore.

stripe/util.py Outdated
api_resources.issuing.Dispute.OBJECT_NAME:
api_resources.issuing.Dispute,
api_resources.issuing.CardDetails.OBJECT_NAME:
api_resources.issuing.CardDetails,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but CardDetails should be after Card.

from stripe.api_resources.issuing.authorization import Authorization
from stripe.api_resources.issuing.card import Card
from stripe.api_resources.issuing.cardholder import Cardholder
from stripe.api_resources.issuing.card_details import CardDetails
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, CardDetails should be after Card.

@remi-stripe
Copy link
Contributor Author

@ob-stripe fixed PTAL

@ob-stripe
Copy link
Contributor

Pulling this in.

@ob-stripe ob-stripe merged commit 0bd9448 into master Jul 26, 2018
@ob-stripe ob-stripe deleted the remi-add-issuing branch July 26, 2018 18:05
@ob-stripe
Copy link
Contributor

Released as 2.2.0 \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants