Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move object_classes and some imports to other files for easier codegen #579

Merged
merged 4 commits into from
May 31, 2019

Conversation

rattrayalex-stripe
Copy link
Contributor

r? @ob-stripe
cc @stripe/api-libraries

stripe/util.py Outdated Show resolved Hide resolved
stripe/__init__.py Show resolved Hide resolved
@rattrayalex-stripe
Copy link
Contributor Author

Updated!
ptal @ob-stripe

@ob-stripe
Copy link
Contributor

LGTM, but you need to run make fmt to fix formatting errors. Feel free to self-approve afterwards.

ptal @rattrayalex-stripe

@rattrayalex-stripe
Copy link
Contributor Author

Oops, sorry I missed that. Done. Also added some reordering to the object_classes for alphabetization (some terminal resources hadn't been properly alphabetized previously). Given the nature of the change, self-approving:

LGTM

@rattrayalex-stripe rattrayalex-stripe merged commit 7a747ba into master May 31, 2019
@ob-stripe ob-stripe deleted the ralex/python-init-imports branch June 3, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants