Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip pycurl if gevent is used #62

Closed
wants to merge 1 commit into from
Closed

Conversation

denik
Copy link

@denik denik commented Feb 27, 2014

pycurl, being a wrapper around C library, blocks the whole process and all green threads rather than the current one.

Unlike urllib2 and requests which are compatible with gevent through monkey patching.

More info about gevent at http://gevent.org

pycurl, being a wrapper around C library, blocks the whole process and all green threads rather than the current one.

Unlike urllib2 and requests which are compatible with gevent through monkey patching.
@danielchatfield
Copy link
Contributor

If requests is available it will use that. This would only be an issue of someone couldn't use requests, and I can't think of a reason why that would happen.

@kyleconroy
Copy link
Contributor

Agreed with @danielchatfield, as pycurl won't be used. @denik are you claiming that just importing pycurl blocks with using gevent?

@kyleconroy
Copy link
Contributor

As I haven't heard back, I'm closing this. Pycurl won't be used when gevent is concerned.

@kyleconroy kyleconroy closed this Jul 29, 2014
@denik
Copy link
Author

denik commented Jul 29, 2014

Agreed with @danielchatfield, as pycurl won't be used. @denik are you claiming that just importing pycurl blocks with using gevent?

if requests is not available, but pycurl is, pycurl will be used and it'll block without a warning.

@kyleconroy
Copy link
Contributor

I'm not sure how that would happen? We explicitly require requests in setup.py. Users have to install PyCurl themselves. So for this to be a problem a user would have to install stripe-python without using pip or easy_install, install PyCurl, and then use gevent. Seems unlikely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants