Support stripe.File.create(stripe_version='...') #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ob-stripe
As reported in #663, in order to override the version in
File.createyou had tostripe.File.create(api_version="...")which is inconsistent with other methods, which call the version parameterstripe_version.This PR adds support for
stripe_version, but support forapi_versionis retained in order to avoid a breaking change.api_ versionwill trumpstripe_versionwhen both are provided.I also made a change to the
Makefilethat lets you specify a path to the python and pip binaries (but only for the invocations of these outside of the virtualenv). This was helpful for me because I couldn't getmake venvto work when pointing to the mac default python 2.7 and had to explicitly point it to the python3 I installed using brew.