Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose returnURL parameter for handleNextAction #1104

Merged

Conversation

charliecruzan-stripe
Copy link
Collaborator

Summary

handleNextAction wasn't redirecting back to the app on iOS. This is bc the return URL has to match the return_url set during payment intent creation on the server (which our SDK will never know). So, this is now exposed as an optional parameter (no breaking change).

Docs changes to https://stripe.com/docs/payments/accept-a-payment-synchronously?platform=react-native will follow

Motivation

closes #772

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@charliecruzan-stripe charliecruzan-stripe merged commit 8758107 into master Aug 26, 2022
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan/fix-returnurl-handlenextaction branch August 26, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handleCardAction not calling returnURL / authentication WebView not closing
1 participant