Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not double-create Stripe token in Apple Pay flow #1243

Merged
merged 5 commits into from
Dec 19, 2022

Conversation

charliecruzan-stripe
Copy link
Collaborator

Motivation

fixes #1236

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@walkerdb
Copy link
Contributor

walkerdb commented Dec 15, 2022

Thanks for the fix! I think you'll also want to update the docs on Platform Pay Migration to no longer mention that createPlatformPayPaymentMethod returns a token

@mjvestal
Copy link

I tested these changes out locally and it solved the issue of using Apple Pay to create a platform payment method on a physical device for me.

@charliecruzan-stripe charliecruzan-stripe merged commit d60c9c0 into master Dec 19, 2022
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan/fix-1236 branch December 19, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 error when using createPlatformPayPaymentMethod for Apple Pay on physical devices
3 participants