Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Push Provisioning issues on iOS due to Apple bugs #1305

Conversation

charliecruzan-stripe
Copy link
Collaborator

Summary

There is some unexpected behavior from Apple we need to account for.

  1. Calling canAddPasses on any iPad will return false, even though the device can add payment passes, so we removed reliance on that method.
  2. There is a bug in iOS which results in the false response from canAddSecureElementPass when a paired Watch is still available for provisioning, so we removed reliance on that method.

Motivation

Temporarily fix push provisioning flow on iPads and when there is a paired watch, until Apple fixes this in PassKit.

Testing

Testing this takes a while, TODO

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@charliecruzan-stripe charliecruzan-stripe merged commit 32e07e5 into master Feb 21, 2023
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan/push-provisioning-work-around-ios-bugs branch February 21, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant