New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: use a cardDetails prop for AddToWalletButton component #913
Merged
charliecruzan-stripe
merged 10 commits into
master
from
charliecruzan-useprimaryaccountidentifierforiospushprovisioning
May 4, 2022
Merged
breaking: use a cardDetails prop for AddToWalletButton component #913
charliecruzan-stripe
merged 10 commits into
master
from
charliecruzan-useprimaryaccountidentifierforiospushprovisioning
May 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidme-stripe
approved these changes
Apr 28, 2022
davidme-stripe
requested changes
Apr 28, 2022
davidme-stripe
approved these changes
Apr 28, 2022
…oriospushprovisioning
lukas-stripe
suggested changes
Apr 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, otherwise looks good (as far as I can follow React Native 😅)
charliecruzan-stripe
deleted the
charliecruzan-useprimaryaccountidentifierforiospushprovisioning
branch
May 4, 2022 17:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modified the props for the
AddToWalletButton
component. Instead of passingcardHolderName
,cardLastFour
,cardDescription
, andcardBrand
directly as props, you will instead pass acardDetails
prop, which is an object containing the following fields:primaryAccountIdentifier
: Thewallet.primary_account_identifier
value from the issued card.name
: The card holder name (previouslycardHolderName
).description
: A user-facing description of the card (previouslycardDescription
).lastFour
: Last 4 digits of the card, optional (previouslycardLastFour
).brand
: The card brand, optional (previouslycardBrand
).Motivation
Stripe iOS recently updated to expose a method that sets the
primaryAccountIdentifier
, and without this push provisioning can fail on iOS. This provided a good opportunity to instead pass acardDetails
rather than individual props for each field.Testing
Note: This was tested via the
STPFakeAddPaymentPassViewController
Documentation
I will update https://stripe.com/docs/issuing/cards/digital-wallets?platform=react-native accordingly