Skip to content

Commit

Permalink
Allow to update a resource without retreiving it first
Browse files Browse the repository at this point in the history
Rationale:

  Sometime you don't care about the current state of a resource
  you just want to update one of it's attributes.
  It should only require one request.

fixes #52

```ruby
  c = Stripe::Customer.new("cus_1EqKjPaFs4ZwDD")
  c.description = 'Ny new Description'
  c.save
```

Before:

```json
{
  error: {
    type: "invalid_request_error",
    message: "A parameter provided in the URL (id) was repeated as a GET or POST parameter. You can only provide this information as a portion of the URL.",
    param: "id",
  }
}
```

After:

Successfully update the customer and return it's whole state.
  • Loading branch information
byroot committed Mar 14, 2013
1 parent ce34d9e commit 6a57264
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
1 change: 1 addition & 0 deletions lib/stripe/api_operations/update.rb
Expand Up @@ -5,6 +5,7 @@ def save
if @unsaved_values.length > 0
values = {}
@unsaved_values.each { |k| values[k] = @values[k] }
values.delete(:id)
response, api_key = Stripe.request(:post, url, @api_key, values)
refresh_from(response, api_key)
end
Expand Down
9 changes: 9 additions & 0 deletions test/test_stripe.rb
Expand Up @@ -447,6 +447,15 @@ class TestStripeRuby < Test::Unit::TestCase
s = c.delete_discount
assert_equal nil, c.discount
end

should "be able to update a customer without refreshing it first" do
@mock.expects(:post).once.with("#{Stripe.api_base}/v1/customers/test_customer", nil, 'mnemonic=bar').returns(test_response(test_customer({:mnemonic => "bar"})))
c = Stripe::Customer.new("test_customer")
c.mnemonic = "bar"
c.save
assert_equal c.mnemonic, "bar"
end

end

context "card tests" do
Expand Down

0 comments on commit 6a57264

Please sign in to comment.