Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update save deprecation message #1201

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

anniel-stripe
Copy link
Contributor

closes #1200

Provide a better deprecation message for the save instance method to make it more clear that update is a class method. The message now looks like:

NOTE: Stripe::Subscription#save is deprecated; use the `update` class method (for examples see https://github.com/stripe/stripe-ruby/wiki/Migration-guide-for-v8) instead. It will be removed on or after 2022-11-01.

@anniel-stripe anniel-stripe merged commit aa05b84 into master Mar 29, 2023
12 checks passed
@anniel-stripe anniel-stripe deleted the anniel-better-save-deprecation-message branch March 29, 2023 18:20
anniel-stripe added a commit that referenced this pull request Mar 30, 2023
* Update generated code (new) (#1197)

* Update generated code for v275

* Update generated code for v276

---------

Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>

* Update generated code for v277 (#1198)

Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>

* Bump version to 8.4.0

* Update save deprecation message (#1201)

* Update save deprecation message

* comma

* Update generated code for v285

* Update generated code for v285 (#1203)

Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>

* Bump version to 8.5.0

---------

Co-authored-by: stripe-openapi[bot] <105521251+stripe-openapi[bot]@users.noreply.github.com>
Co-authored-by: Pavel Krymets <pakrym@stripe.com>
Co-authored-by: anniel-stripe <97691964+anniel-stripe@users.noreply.github.com>
Co-authored-by: Annie Li <anniel@stripe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid warning message on deprecated method Stripe::Subscription#save
2 participants