Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rubocop #1295

Merged
merged 8 commits into from
Nov 28, 2023
Merged

Upgrade rubocop #1295

merged 8 commits into from
Nov 28, 2023

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Nov 28, 2023

Our Rubocop version is a little behind (it won't even load up on the latest "Ruby" VSCode plugin). In this PR I

  • Upgraded the version to the latest.
  • Ran --autocorrect (I only did the "safe autocorrect" fixes)
  • Generated a new Rubocop config. I've left all the "new" rules that have been added to Rubocop since last upgrade enabled, and just suppressed the violations that couldn't be automatically fixed.
  • Ran --update-todos to suppress all the unsafe autocorrections, or the autocorrects that couldn't automatically be resolved.

Copy link
Contributor

@anniel-stripe anniel-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@richardm-stripe richardm-stripe merged commit ddb922b into master Nov 28, 2023
12 checks passed
@richardm-stripe richardm-stripe deleted the richardm-upgrade-rubocop branch November 28, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants