Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start running Sorbet in CI #1324

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Start running Sorbet in CI #1324

merged 2 commits into from
Feb 12, 2024

Conversation

helenye-stripe
Copy link
Contributor

No description provided.

@helenye-stripe helenye-stripe force-pushed the helenye-test-sorbet branch 2 times, most recently from e3f99ce to 192573c Compare February 12, 2024 20:40
@helenye-stripe helenye-stripe marked this pull request as ready for review February 12, 2024 21:31
@helenye-stripe helenye-stripe requested review from a team, pakrym-stripe and richardm-stripe and removed request for a team and pakrym-stripe February 12, 2024 21:32
richardm-stripe
richardm-stripe approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@richardm-stripe richardm-stripe left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Took the liberty of renaming the PR.

@richardm-stripe richardm-stripe changed the title sorbet test Start running Sorbet in CI Feb 12, 2024
@helenye-stripe helenye-stripe merged commit 06d1bfb into master Feb 12, 2024
13 checks passed
@bslobodin
Copy link

@helenye-stripe @richardm-stripe 👋 we're seeing this warning in the app that uses stripe gem and tapioca via other dependency paths, and I think it's related to this change? If it doesn't ring any bells, I'll try to repro with a simple app,

git:(main) bin/tapioca gem
The `tapioca` executable in the `tapioca` gem is being loaded, but it's also present in other gems (stripe).
If you meant to run the executable for another gem, make sure you use a project specific binstub (`bundle binstub <gem_name>`).
If you plan to use multiple conflicting executables, generate binstubs for them and disambiguate their names.

@helenye-stripe
Copy link
Contributor Author

@bslobodin Thanks for bringing this to our attention! The tapioca executable will be excluded from the next release onward, #1362.

@ramya-stripe
Copy link
Contributor

The latest release of the stripe-ruby library has this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardm-stripe richardm-stripe richardm-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@helenye-stripe @bslobodin @ramya-stripe @richardm-stripe