Fix payment intent methods to take extra parameters #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-fix-payment-intent
branch
from
44704e9
to
0632afb
Compare
|
Wrong thread. Not released as 44.0.0 :) |
|
LGTM. Thanks!
Yep, agreed. |
|
Released as 3.25.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copy/pasted the example from a resource that does not take parameters. The
/cancelone does not take parameters yet but will in the future.Also remove the ability to delete that resource since it was never supported.
I don't think it's a breaking change since parameters are optional but flagging to be safe.
r? @brandur-stripe
cc @stripe/api-libraries