Update minimum stripe-mock version to 0.94.0 #935
Conversation
|
I'm not too familiar with OpenAPI, but it doesn't look like My assumption is that the minimum version usually gets bumped instead of setting a |
There was a problem hiding this comment.
Thanks for doing the work @joeltaylor. Left a comment that I hope you can fix (or I can take if you prefer)
test/stripe/account_link_test.rb
Outdated
| failure_url: "https://stripe.com/failure", | ||
| success_url: "https://stripe.com/success", | ||
| refresh_url: "https://stripe.com/refresh", | ||
| return_url: "https://stripe.com/return", | ||
| type: "custom_account_verification" |
There was a problem hiding this comment.
Can you change this to account_onboarding and pin to stripe-mock 0.94.0 directly? The latest version I released has that other change and so at least it minimizes issues for someone who installed the latest again
joeltaylor
force-pushed
the
update-minimum-stripe-mock-version
branch
from
84484f4
to
8b0113d
Compare
joeltaylor
changed the title
The params for AccountLink changed in `v0.93.0`, which will cause the test suite to fail unless `stripe-mock` is pinned to an earlier version. Fixes stripe#934
|
I'm waiting on tests to pass and then I will merge! I won't do a release since it's a test suite change but that will let you rebase easily! |
joeltaylor
force-pushed
the
update-minimum-stripe-mock-version
branch
from
8b0113d
to
aea12eb
Compare
|
Thanks! Just updated the commit message to reflect the change to |
The params for AccountLink changed in
v0.93.0, which will cause the test suite to fail unlessstripe-mockis pinned to an earlier version.Fixes #934