Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper v1 (gh issues) #13

Merged
merged 16 commits into from
May 11, 2020
Merged

Proper v1 (gh issues) #13

merged 16 commits into from
May 11, 2020

Conversation

harryherbig
Copy link
Contributor

Fixes #6
Fixes #7
Fixes #8
Fixes #10
Fixes #11
Fixes #12

  • move java files to subfolder
  • adapt to github issues

@github-actions
Copy link

🔥 Breaking Changes

<input>:1:1:Previously present file "article/v1/article.proto" was deleted.

@stroeer stroeer deleted a comment from github-actions bot May 11, 2020
bobaaaaa
bobaaaaa approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@bobaaaaa bobaaaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harryherbig harryherbig merged commit 3be4103 into master May 11, 2020
@harryherbig harryherbig deleted the proper_v1 branch May 11, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobaaaaa bobaaaaa bobaaaaa approved these changes

@moritzzimmer moritzzimmer Awaiting requested review from moritzzimmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@harryherbig @bobaaaaa