chore: update plugins #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kev-Hoffmann
requested review from
moritzzimmer,
harryherbig,
thisismana,
bobaaaaa,
saefty and
jadiedrich
as code owners
moritzzimmer
added
the
🔄 dependencies
Makefile
Outdated
| @@ -27,6 +27,11 @@ test: generate ## Runs all tests | |||
| @cd java && ./gradlew clean build | |||
| @cd node && npm run checks | |||
|
|
|||
| .PHONY: node-examples | |||
| node-examples: ## Runs all tests | |||
|
@bobaaaaa can you check the node changes? |
bobaaaaa
reviewed
Sep 25, 2023
Comment on lines
+66
to
+79
|
|
||
| ### Build examples | ||
|
|
||
| ```bash | ||
| npm run examples:build | ||
| ``` | ||
|
|
||
| ### Run examples | ||
|
|
||
| Make sure that you have set the GRPC_HOST and GRPC_API_TOKEN environment variables | ||
|
|
||
| ```bash | ||
| npm run examples:grpc-js:run | ||
| ``` |
There was a problem hiding this comment.
(nit)
There is also a README in node-proto + examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.