Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated field related_articles from ArticlePage #526

Merged
merged 2 commits into from
Feb 13, 2024
Merged

chore: remove deprecated field related_articles from ArticlePage #526

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a6af1a
delete unused relatedArticles field
harryherbig Feb 12, 2024
85e71aa
don't reserve number of removed field
harryherbig Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions stroeer/page/article/v1/article_page.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
syntax = "proto3";

Check failure on line 1 in stroeer/page/article/v1/article_page.proto

View workflow job for this annotation

GitHub Actions / breaking 

Previously present enum "RelatedArticleSource" was deleted from file.

Check failure on line 1 in stroeer/page/article/v1/article_page.proto

View workflow job for this annotation

GitHub Actions / breaking 

Previously present message "RelatedArticle" was deleted from file.

package stroeer.page.article.v1;

Expand All @@ -9,17 +9,12 @@
option go_package = "github.com/stroeer/go-tapir/page/article/v1;article";

// Article page with all render relevant data for the user and SEO bots.
message ArticlePage {

Check failure on line 12 in stroeer/page/article/v1/article_page.proto

View workflow job for this annotation

GitHub Actions / breaking 

Previously present field "2" with name "related_articles" on message "ArticlePage" was deleted.
// The editorial article with the ID of a `GetArticlePageRequest`.
//
// Unpublished elements will be filtered according to their metadata.
stroeer.core.v1.Article article = 1;

// Additional related editorial articles. Articles which are not published
// according to their `Metadata` will be filtered.
// deprecated in favor `core.Article.relatedArticles`
repeated RelatedArticle related_articles = 2 [deprecated = true];

// stages for article pages contain companions, links to topic pages, A-Z Modules etc.
// configuration.fields contains a `stage_type`, which defines the rendering position
repeated stroeer.page.stage.v1.Stage stages = 3;
Expand All @@ -34,28 +29,3 @@
// - external references
stroeer.core.v1.Reference navigation_menu = 4;
}

// An editorial article, which is related to another article.
//
// Related articles are specified manually be the editorial department or
// identified by recommendation systems.
message RelatedArticle {
// Data of the related article. This message will only contain data required
// to render the article as a _Teaser_ (e.g. with `Article.body` set to `null`
// thus not containing any data that is only required on detail pages).
stroeer.core.v1.Article article = 1;

// Deprecated (since 04.04.2023) source of the related article in form of an enum.
RelatedArticleSource source = 2;

// Source of the related article.
string related_article_source = 3;
}

enum RelatedArticleSource {
// Not specified.
RELATED_ARTICLE_SOURCE_UNSPECIFIED = 0;

// Article was related manually by the editorial department.
RELATED_ARTICLE_SOURCE_EDITORIAL = 1;
}
Loading