Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new element for paper's own widgets #528

Merged
merged 5 commits into from
Apr 12, 2024
Merged

feat: new element for paper's own widgets #528

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
586632c
feat: new element for paper's own widgets
thisismana Apr 11, 2024
dafb027
rename type
jmeischner Apr 12, 2024
484ee9d
fix typo
jmeischner Apr 12, 2024
aacb17e
Update stroeer/core/v1/article.proto
jmeischner Apr 12, 2024
0d6835c
format comment
jmeischner Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions stroeer/core/v1/article.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,7 @@ message Article {
* | `AGENCY` | author, contains one `metadata` [`Asset`][a] |
* | `EDGE_SIDE_INCLUDE` | `<esi:include>` that must be resolved server-side for SEO reasons, otherwise similar to `OEMBED` |
* | `CITATION` | oEmbed, contains one `metadata` [`Asset`][a]. Todo: sample |
* | `INTERNAL_WIDGET` | widget or embed that is handled directly by the front end rendering Todo: sample |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* | `INTERNAL_WIDGET` | widget or embed that is handled directly by the front end rendering Todo: sample |
* | `INTERNAL_WIDGET` | widget or embed that is handled directly by the front end rendering |

Can we add 1-2 examples here like: dpa widgets, wahl-o-mat iframe

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo sample ^__^

*
* [a]: article_%DB%B0_element_%DB%B0_asset.html
* [e]: #element
Expand All @@ -291,6 +292,7 @@ message Article {
AGENCY = 7;
EDGE_SIDE_INCLUDE = 8;
CITATION = 9;
INTERNAL_WIDGET = 10;
}
/** @CodeBlockEnd */

Expand Down
Loading