-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Github Action that deploys the hello-strongbox-npm into the Github Package Registry #24
Conversation
Key thing here is that name field in the package.json name field should should match the GitHub repository name.
Example commit: https://github.com/j4ckofalltrades/strongbox-examples/commit/4279e0adc5404fdbc34b740fac21944f83664398 |
@carlspring Requesting review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
@steve-todorov : What are your thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The only small note I have is the file name should be called gh-registry.yml
since this workflow will be only for this purpose.
…thub Package Registry Refs #1927
Updated file name to |
Works like a charm! Great job! :) Just one question to clarify things for myself. Do I need to set |
Excellent job, thank you! :) |
GitHub provides it automatically for you. https://docs.github.com/en/free-pro-team@latest/actions/reference/authentication-in-a-workflow |
Cool! Thanks for the clarification! :) |
Refs strongbox/strongbox#1927