Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Github Action that deploys the hello-strongbox-npm into the Github Package Registry #24

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

j4ckofalltrades
Copy link
Contributor

@j4ckofalltrades j4ckofalltrades commented Oct 22, 2020

@j4ckofalltrades
Copy link
Contributor Author

Key thing here is that name field in the package.json name field should should match the GitHub repository name.
From docs:

By default, GitHub Packages publishes a package in the GitHub repository you specify in the name field of the package.json file. For example, you would publish a package named @my-org/test to the my-org/test GitHub repository. For more information, see npm-scope in the npm documentation.

Example commit: https://github.com/j4ckofalltrades/strongbox-examples/commit/4279e0adc5404fdbc34b740fac21944f83664398
Example package: https://github.com/j4ckofalltrades/strongbox-examples/packages/468529

@j4ckofalltrades
Copy link
Contributor Author

@carlspring Requesting review.

Copy link
Member

@carlspring carlspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@steve-todorov : What are your thoughts on this?

Copy link
Member

@steve-todorov steve-todorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The only small note I have is the file name should be called gh-registry.yml since this workflow will be only for this purpose.

@j4ckofalltrades
Copy link
Contributor Author

Updated file name to gh-registry.yml.

@steve-todorov steve-todorov merged commit 7f409a3 into strongbox:master Oct 23, 2020
@steve-todorov
Copy link
Member

Works like a charm! Great job! :)

Just one question to clarify things for myself. Do I need to set GH_TOKEN secret or GH Actions picks it up on it's own?
I did add one, but wanted to check if you also added it.

@carlspring
Copy link
Member

Excellent job, thank you! :)

@j4ckofalltrades j4ckofalltrades deleted the issue-1927 branch October 23, 2020 12:07
@j4ckofalltrades
Copy link
Contributor Author

@steve-todorov

Do I need to set GH_TOKEN secret or GH Actions picks it up on it's own? I did add one, but wanted to check if you also added it.

GitHub provides it automatically for you.

https://docs.github.com/en/free-pro-team@latest/actions/reference/authentication-in-a-workflow

@carlspring
Copy link
Member

Cool! Thanks for the clarification! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants